Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uring poll ring is broken #22

Open
glommer opened this issue Sep 30, 2020 · 3 comments
Open

uring poll ring is broken #22

glommer opened this issue Sep 30, 2020 · 3 comments

Comments

@glommer
Copy link
Contributor

glommer commented Sep 30, 2020

This is because liburing broke it with their commit axboe/liburing@f0c5c54

It was fixed (by reverting) by axboe/liburing@1bafb3c, and then a unit test was added by axboe/liburing@5964134

Could we update liburing to include at least those commits?

@withoutboats
Copy link
Collaborator

withoutboats commented Sep 30, 2020

Ugh that's a shame.

I've been trying to keep released versions of uring-sys pinned to specific release commits of liburing, was a patch commit released? I notice its been nearly 3 months since liburing had a release, do you know if there is an 0.8 release planned soon?

If the answer to these questions is no I'll consider pinning to the fix commit and making a new release.

Either way, until I make a new release, you can fork, update the git submodule and make iou use your fork with a cargo patch. That way you're unblocked.

@glommer
Copy link
Contributor Author

glommer commented Sep 30, 2020

Hey, thanks! I am not blocked and indeed I am using private versions. I would like to move back to using your upstream eventually, so this is mostly so we can track that.

It does make sense to keep it pinned to release versions, thanks!

I can ask Axboe when he plans to release 0.8 and I'll get back to you

@PureWhiteWu
Copy link

PureWhiteWu commented Jul 30, 2021

Gello, seems liburing 2.0 is release now, do you plan to update to it?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants