Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace button for Dial Pad #236

Open
tylerlong opened this issue Jun 9, 2017 · 1 comment
Open

Backspace button for Dial Pad #236

tylerlong opened this issue Jun 9, 2017 · 1 comment

Comments

@tylerlong
Copy link
Contributor

JS widget:

image

RingCentral for Mac

image

From the screenshots above you can see that a Backspace button is missing from JS widget.

I noticed it the first time I used the Dial Pad.

And it is a must-have if we do have plan to support mobile.

@u9520107
Copy link
Contributor

Since this component is also used internally for one of our soon to be public production app, I am not exactly sure if we should just add the enhancement. If we are to modify this particular component, we need to talk to the PM's about it first, as well as define the behaviors we want with such changes.

However, if you are eager to make a prototype and submit it via PR, I think you can create a DialPad2 component that is based on the original and submit it as an enhanced version that we can use to use in certain apps.

What I think we'd also need is to discuss the need to have versioned components. I can anticipate that in our internally developed applications based on this lib, there will be cases where some apps requires certain features that are totally different than another. Rather than building all the features into one component and just use flags to turn them on/off, we can probably build them into different components that may (or may not) have a common base component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants