Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of the boolean parameter in Authenticate User method #14

Closed
bdeanindy opened this issue Nov 12, 2015 · 2 comments
Closed

Use of the boolean parameter in Authenticate User method #14

bdeanindy opened this issue Nov 12, 2015 · 2 comments

Comments

@bdeanindy
Copy link

Reading the documentation for Authenticate User, there is a comment after the example code in the README.md file which says:

// change true to false to not remember user

But the example code doesn't show the use of either boolean value:

$sdk->getPlatform()->login('username', 'extension (or leave blank)', 'password');

Additionally, after looking at the login method definition, there isn't any use of a boolean value:
https://github.com/ringcentral/ringcentral-php/blob/master/src/Platform/Platform.php#L113

@kirill-konshin
Copy link
Contributor

PHP SDK used to have it just like JS SDK does. But it's useless functionality for server-side so it has been removed, README.md has to be updated. A PR is welcome :)

@ITJamie
Copy link

ITJamie commented Jan 9, 2016

Ive done some updates in a pull request to readme.md with some errors in the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants