response module: .notModified() and .redirect() break chainability

[grob]

.notModified() and .redirect() both return a plain JS object instead of this (a JsgiResponse instance), which breaks chainability and leads to errors with the current Stick CORS middleware (which requires the addHeaders() method of the response).

I couldn't figure out the reason for this, besides that normally no other response parameters are set in case of a 303 or 304, but for consistency reasons imho both methods should return the JsgiResponse instance.

[oberhamsi]

looks like an oversight. I opened a PR:

https://github.com/ringo/ringojs/tree/response-always-return-this

/cc @botic

[grob]

i already had a commit locally that changed to always return this (since @botic also considered this an oversight), and accidentally committed it right now. sorry for that.

[botic]

Yep, this looks like code from the previous JsgiRepsonse slipped into the new module since I don't considered use cases to chain redirects or not modified. Makes sense to keep the chain intact.