Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CloudFront price_class attribute configurable #18

Closed
mojeto opened this issue Mar 8, 2018 · 2 comments
Closed

Make CloudFront price_class attribute configurable #18

mojeto opened this issue Mar 8, 2018 · 2 comments

Comments

@mojeto
Copy link
Contributor

mojeto commented Mar 8, 2018

Hi,
I have a feature request

What:

Expose CloudFront price_class attribute as an optional module variable.

Why

So I can define where on the world a website is fast accessible.

Let me know if you like this feature.
I'm willing to create a PR.

Cheers and thank you for a great module.
@MattiasGees
Copy link
Contributor

@mojeto sounds great. We will have no problem accepting this kind of feature.

@mojeto mojeto mentioned this issue Mar 13, 2018
Merged
@MattiasGees
Copy link
Contributor

Released in https://github.com/ringods/terraform-website-s3-cloudfront-route53/releases/tag/3.0.5 and solved with #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattiasGees @mojeto