Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termi-Lua.Opencalc issues and enhancements #2

Closed
hahahahacker2009 opened this issue Feb 10, 2022 · 11 comments
Closed

Termi-Lua.Opencalc issues and enhancements #2

hahahahacker2009 opened this issue Feb 10, 2022 · 11 comments
Labels
bug Something isn't working enhancement New feature or request Fixed Issue is fixed

Comments

@hahahahacker2009
Copy link
Member

Enhancement: Add separates functions to do their own work, for example Calculator's function when people call the calculator command
Enhancement: Termi-Lua.Opencalc, Termi-Lua.OpenGeocalc: Print when asking about numbers.

Enhancement: Create a command-list variable (array), when user enter a command, just check if the command exist in the command list.
Issue: Termi-Lua.AllCommands: Response if user put in the unexpected value

image

Hope this can improves the project!

@Andrej123456789 Andrej123456789 added bug Something isn't working enhancement New feature or request labels Feb 10, 2022
@Andrej123456789
Copy link
Member

image

@Andrej123456789
Copy link
Member

My output

@StjepanBM1
Copy link
Member

StjepanBM1 commented Feb 11, 2022

To comment on your issue:

  1. Photo>
    If you think that you can calculate r+r and that it would show a result?, I have bad news. No calculator can calculate r+r

  2. Photo>
    In what universe will ff make a valid output? Geo-calc is a geometric calculator, and please can you explain what did you want to do with rr?

To conclude:
These issues can simply dumb user mistakes.

@Andrej123456789
Copy link
Member

In maths you can enter e

@StjepanBM1
Copy link
Member

Yes I know that but what is r+r?

@Andrej123456789
Copy link
Member

Check input and send message Operation invalid

@StjepanBM1
Copy link
Member

Yea will add that in Version 0.0.3

@Andrej123456789
Copy link
Member

Ok but then don't close this issue

@StjepanBM1 StjepanBM1 added the Fixed Issue is fixed label Feb 11, 2022
@hahahahacker2009
Copy link
Member Author

To comment on your issue:

  1. Photo>
    If you think that you can calculate r+r and that it would show a result?, I have bad news. No calculator can calculate r+r
  2. Photo>
    In what universe will ff make a valid output? Geo-calc is a geometric calculator, and please can you explain what did you want to do with rr?

To conclude: These issues can simply dumb user mistakes.

still need to tell the user if there inputs are invalid

@StjepanBM1
Copy link
Member

Well, that is the plan for version 0.0.3 but still I do think that common user will know how to use a calculator

@hahahahacker2009
Copy link
Member Author

Well, that is the plan for version 0.0.3 but still I do think that common user will know how to use a calculator

hope that 0.0.3 will be release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Fixed Issue is fixed
Projects
None yet
Development

No branches or pull requests

3 participants