Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at high zoom levels for RTL countries #39

Closed
rinigus opened this issue Dec 26, 2018 · 3 comments
Closed

Crash at high zoom levels for RTL countries #39

rinigus opened this issue Dec 26, 2018 · 3 comments

Comments

@rinigus
Copy link
Owner

rinigus commented Dec 26, 2018

As reported by @Planetos in rinigus/pure-maps#121

Unfortunately now the app closes/crashes if I zoom into an OSM map as soon as I reach zoom-level 1km - according to the measure in lower left corner. This happens where languages are written from right to left.
Tested on Sailfish on ARM.

Further observations:

I can reproduce it with Lebanon, on phone (SFOS) and on desktop. When using QtLocation based map viewer there is no crash. So, something is wrong with BiDi handling in QMapboxGL version compiled by me. In my version, the library is compiled with use_icu flag that uses platform/default/bidi.cpp to render RTL languages correctly (same didn't work with platform/qt/src/bidi.cpp).

Would have to check how to make platform/qt/src/bidi.cpp to work correctly and not lead to rinigus/pure-maps#121 . I presume that Qt version is used in QtLocation and there it works as expected.

/cc @Planetos

@rinigus
Copy link
Owner Author

rinigus commented Dec 29, 2018

Update: found the commit that fixed the issue. Now will look into update of qmapboxgl library to incorporate that. At least, we are on the way to fix it

@rinigus
Copy link
Owner Author

rinigus commented Dec 29, 2018

Fixed with 1.5.0.0 release

@rinigus rinigus closed this as completed Dec 29, 2018
@rinigus
Copy link
Owner Author

rinigus commented Dec 30, 2018

@Planetos: the updated version was released at OpenRepos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant