Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is Track.external_ids.isrc? #14

Closed
zacwolfe opened this issue Apr 8, 2019 · 3 comments
Closed

Where is Track.external_ids.isrc? #14

zacwolfe opened this issue Apr 8, 2019 · 3 comments

Comments

@zacwolfe
Copy link

zacwolfe commented Apr 8, 2019

I'm relying on ISRC to identify tracks and noticed that you have omitted the external_ids object from the track object. What was the reasoning behind this?

BTW, congrats and thanks for the excellent library!

@rinukkusu
Copy link
Owner

Good catch, with the serialization library I've used when starting this project it wasn't possible to serialize and deserialize objects of type Map<i,j>. Seems json_serializable is capable of this - will report back soon 😄

@rinukkusu
Copy link
Owner

I've added concrete classes for these maps, since in the api docs they state the keys, they use - I think it's more convenient that way instead of using a map object.

@zacwolfe
Copy link
Author

zacwolfe commented Apr 8, 2019

Fixed in an hour, now that's service!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants