Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

PHP 8 support #52

Closed
marvinosswald opened this issue Jan 16, 2021 · 3 comments
Closed

PHP 8 support #52

marvinosswald opened this issue Jan 16, 2021 · 3 comments

Comments

@marvinosswald
Copy link

marvinosswald commented Jan 16, 2021

https://github.com/felixkiss/uniquewith-validator is still php 7 bound, maybe drop the dependency as it seems stale.
Sadly like this your fantastic lib isn't compatible with php 8.

@Omranic
Copy link
Member

Omranic commented Jan 17, 2021

felixkiss/uniquewith-validator is not required by this package, in fact none of our packages require it.

We're using a forked version rinvex/tmp-felixkiss-uniquewith-validator for all latest releases which is compatible with PHP v8.

Make sure you're trying latest release of the package, and let me know if you still believe there's a compatibility issue.

@Omranic Omranic closed this as completed Jan 17, 2021
@marvinosswald
Copy link
Author

I see, thanks for taking the time. I've went down my composer requirements rabbit hole and found the issue being that you locked the required php version to v8.0.0 here : https://github.com/rinvex/tmp-watson-validating/blob/master/composer.json#L17 you probably want this to be more open to future php 8 versions.

But i'm on 8.0.1 by now system wide.

created a PR: rinvex/tmp-watson-validating#1

@Omranic
Copy link
Member

Omranic commented Jan 17, 2021

Thank you for catching this, PR merged 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants