Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

I think here should be $interval instead of $this->interval . #42

Closed
guoxiangke opened this issue Oct 31, 2018 · 6 comments
Closed

I think here should be $interval instead of $this->interval . #42

guoxiangke opened this issue Oct 31, 2018 · 6 comments

Comments

@guoxiangke
Copy link

$method = 'add'.ucfirst($this->interval).'s';

@guoxiangke
Copy link
Author

$user->newSubscription('main', $plan);
TypeError: ucfirst() expects parameter 1 to be string, null given

@tutations
Copy link

Same problem

@Karan1458
Copy link

I think maintainer is not active. Otherwise someone has already reported this issue in past months.

Pull Request

@Omranic
Copy link
Member

Omranic commented Dec 22, 2018

Fixed in #27

@Omranic Omranic closed this as completed Dec 22, 2018
@ProjectInfinity
Copy link

Why was this not merged into master and released with 1.0.1? This is still unusable because $this->interval is null.

@Omranic
Copy link
Member

Omranic commented Dec 30, 2018

@ProjectInfinity Done https://github.com/rinvex/laravel-subscriptions/releases/tag/v1.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants