Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when LightCurve exptime is set to 0.0 #23

Closed
Bmorgado19 opened this issue May 29, 2020 · 1 comment · Fixed by #24
Closed

Crash when LightCurve exptime is set to 0.0 #23

Bmorgado19 opened this issue May 29, 2020 · 1 comment · Fixed by #24
Assignees
@Bmorgado19
Labels
bug Something isn't working effort_low Probably easy to solve lightcurve
Milestone
V0.1.1

Comments

@Bmorgado19
Copy link
Collaborator

There are no protections when the user adds the exptime of choice. If 0.0 or a negative value is added as exptime the model crash and will not be created.
@Bmorgado19 Bmorgado19 added bug Something isn't working effort_low Probably easy to solve lightcurve labels May 29, 2020
@Bmorgado19 Bmorgado19 added this to the V0.1.1 milestone May 29, 2020
@Bmorgado19 Bmorgado19 self-assigned this May 29, 2020
@Bmorgado19 Bmorgado19 mentioned this issue May 29, 2020
Merged
@altairgomes
Copy link
Collaborator

The correction has been made and will be available in v0.1.1.

@Bmorgado19 Bmorgado19 linked a pull request May 31, 2020 that will close this issue
Debugging the LightCurve Class and updates at Occultation log #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bmorgado19 Bmorgado19

Labels
bug Something isn't working effort_low Probably easy to solve lightcurve
Projects
None yet
Milestone
V0.1.1
Development

Successfully merging a pull request may close this issue.

Debugging the LightCurve Class and updates at Occultation log
2 participants
@altairgomes @Bmorgado19