Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding include list of folders as another option besides exclude list #2

Closed
chodorowicz opened this issue May 2, 2021 · 2 comments
Closed
Assignees

Comments

@chodorowicz
Copy link

Hey!
Thanks for this extension. I was looking for a way to do this kind of operation.

What do you think about adding also includeFolders options as an additional way to define what folders would be included. Include lists are generally safer than exclude lists. It's because you need to intentionally define for what items some actions will be performed. With exclude lists it's easy to forget about some folder since by default everything is included besides items in exclude lists.

E.g. I'd like to define includeList: ["src"] to be sure that only files inside src folder will be affected.

@rioj7 rioj7 self-assigned this May 9, 2021
@rioj7 rioj7 closed this as completed in 95de272 May 15, 2021
@rioj7
Copy link
Owner

rioj7 commented May 15, 2021

@chodorowicz Try v0.3.0, includeFolders is an array with Glob Patterns. Best to use ["/src/"] for your example

@chodorowicz
Copy link
Author

I've tried it out and it works flawlessy for me! Amazing! Thanks so much 🙇‍♂️ 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants