fix: handle nullable correctly in nullable disabled contexts for generics and arrays #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
force-pushed
the
fix-nullable-generic-prop
branch
3 times, most recently
from
d394204
to
9bcf75d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 91.30% 91.24% -0.07%
==========================================
Files 220 220
Lines 7168 7184 +16
Branches 911 909 -2
==========================================
+ Hits 6545 6555 +10
- Misses 412 414 +2
- Partials 211 215 +4 ☔ View full report in Codecov by Sentry. |
latonz
force-pushed
the
fix-nullable-generic-prop
branch
5 times, most recently
from
4c5d707
to
6cf764d
Compare
latonz
changed the title
latonz
force-pushed
the
fix-nullable-generic-prop
branch
from
6cf764d
to
0a2b804
Compare
ni507
approved these changes
Jan 2, 2024
|
🎉 This PR is included in version 3.4.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
trejjam
reviewed
Jan 6, 2024
R-abodyak
pushed a commit
to R-abodyak/mapperly
that referenced
this pull request
Jan 18, 2024
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1025 (comment)