New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add mapper attribute PreferParameterlessConstructors #1061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to Mapperly! I added my feedback, feel free to discuss any points or ask questions.
src/Riok.Mapperly/Descriptors/MappingBodyBuilders/NewInstanceObjectMemberMappingBodyBuilder.cs
Outdated
Show resolved
Hide resolved
The new public API can be added to the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 91.18% 91.18% -0.01%
==========================================
Files 220 220
Lines 7192 7203 +11
Branches 913 915 +2
==========================================
+ Hits 6558 6568 +10
Misses 418 418
- Partials 216 217 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few linter checks are still failing, otherwise this looks good to me 😊
https://github.com/riok/mapperly/actions/runs/7533542937/job/20521692711?pr=1061#step:4:140
https://github.com/riok/mapperly/actions/runs/7533542928/job/20521691733?pr=1061#step:8:11
Hi @latonz , can you check them now ? |
You can run the linters locally. Find the commands in the workflow files: mapperly/.github/workflows/lint.yml Lines 18 to 22 in cdee78b
mapperly/.github/workflows/docs.yml Lines 54 to 59 in cdee78b
Since this is your first PR on this repo I need to approve each pipeline run manually. Further PR pipelines should run automatically. for the docs you can usually simply run |
Bumps [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 2.0.127 to 2.0.132. - [Release notes](https://github.com/meziantou/Meziantou.Analyzer/releases) - [Commits](meziantou/Meziantou.Analyzer@2.0.127...2.0.132) --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
riok#1049) The value runtime already indicates the runtime meaning
…ok#1059) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lints fix
77de057
to
b6fe3c3
Compare
🎉 This PR is included in version 3.4.0-next.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
add mapper attribute PreferParameterlessConstructors
Controls the priority of constructors used in mapping
When enabled, a parameterless constructor is prioritized over constructors with parameters. When disabled, accessible constructors are ordered in descending order by their parameter count.
Fixes #885
Checklist