Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate usage of MapProperty attributes on enum and queryable mapping methods #1074

Merged
merged 1 commit into from Feb 23, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jan 19, 2024

Closes #868

  • Refactors and simplifies the internal configuration mechanisms
  • Emits diagnostics if property configurations are placed on queryable projection mappings
  • Emits diagnostics if enum configurations are placed on object mappings
  • Emits diagnostics if property configurations are placed on enum mappings

@latonz latonz self-assigned this Jan 19, 2024
@latonz latonz force-pushed the simplify-configuration branch 3 times, most recently from c9576b1 to a03c8bb Compare January 25, 2024 06:58
@latonz latonz force-pushed the simplify-configuration branch 3 times, most recently from 64c5611 to 1990846 Compare February 23, 2024 07:08
@latonz latonz changed the title chore: simplify configuration feat: validate usage of MapProperty attributes on enum and queryable mapping methods Feb 23, 2024
@latonz latonz marked this pull request as ready for review February 23, 2024 12:15
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 91.09589% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 91.35%. Comparing base (edc4933) to head (31e0efd).

Files Patch % Lines
...apperly/Configuration/MapperConfigurationReader.cs 79.31% 8 Missing and 4 partials ⚠️
...iptors/MappingBuilders/EnumerableMappingBuilder.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   91.44%   91.35%   -0.10%     
==========================================
  Files         226      226              
  Lines        7566     7614      +48     
  Branches      968      975       +7     
==========================================
+ Hits         6919     6956      +37     
- Misses        421      429       +8     
- Partials      226      229       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz enabled auto-merge (squash) February 23, 2024 12:25
@latonz latonz merged commit fbe7894 into riok:main Feb 23, 2024
17 of 19 checks passed
@latonz latonz deleted the simplify-configuration branch February 23, 2024 12:55
Copy link

github-actions bot commented Mar 9, 2024

🎉 This PR is included in version 3.5.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report a diagnostic if configuration attributes are applied to queryable projection methods
2 participants