fix: resolve user mappings correctly when reference handling is enabled #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 91.43% 91.31% -0.12%
==========================================
Files 230 230
Lines 7799 7788 -11
Branches 989 987 -2
==========================================
- Hits 7131 7112 -19
- Misses 433 441 +8
Partials 235 235 ☔ View full report in Codecov by Sentry. |
latonz
force-pushed
the
1154-reference-handling-default-user-mappings
branch
from
8cf686f
to
8e55706
Compare
* Removes the BuildPriority of a Mapping, all mappings are built with the same priority. This is not needed anymore as user defined mappings with reference handling enabled but no reference handler parameter just delegate to the a generated version of the mapping with a reference handler parameter. * Removes CallableByOthers of a Mapping, all mappings are now considered callable by others For runtime target type mappings there is no type match anyway. And user defined mappings with reference handling enabled but no reference handler parameter just delegate to the version with a reference handler parameter now.
latonz
force-pushed
the
1154-reference-handling-default-user-mappings
branch
from
8e55706
to
0ad1699
Compare
CommonGuy
approved these changes
Mar 11, 2024
|
🎉 This PR is included in version 3.5.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves user mappings correctly (especially with new
[UserMapping]s) when reference handling is enabled without explicit reference handling parameters on the user mappings.Fixes #1154