Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore accessible source properties with inaccessible getters and accessible target properties with inaccessible getters #141

Merged
merged 1 commit into from Sep 16, 2022

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Sep 15, 2022

Closes #140

@latonz latonz force-pushed the 140-property-inaccessible-getter-or-setter branch 2 times, most recently from 841daab to c1541b7 Compare September 15, 2022 17:23
@latonz latonz self-assigned this Sep 15, 2022
@latonz latonz enabled auto-merge (squash) September 15, 2022 17:36
@latonz latonz force-pushed the 140-property-inaccessible-getter-or-setter branch from c1541b7 to f879b46 Compare September 16, 2022 05:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #141 (1bb2e01) into main (a9926ac) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   89.97%   89.85%   -0.13%     
==========================================
  Files          76       76              
  Lines        2475     2475              
  Branches      308      308              
==========================================
- Hits         2227     2224       -3     
  Misses        181      181              
- Partials       67       70       +3     
Impacted Files Coverage Δ
...ors/MappingBuilder/ObjectPropertyMappingBuilder.cs 97.74% <0.00%> (-2.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…d accessible target properties with inaccessible getters
@latonz latonz force-pushed the 140-property-inaccessible-getter-or-setter branch from f879b46 to 1bb2e01 Compare September 16, 2022 05:58
@latonz latonz added the bug Something isn't working label Sep 16, 2022
@latonz latonz merged commit d39ace7 into riok:main Sep 16, 2022
@latonz latonz deleted the 140-property-inaccessible-getter-or-setter branch September 16, 2022 06:03
@github-actions
Copy link

🎉 This PR is included in version 2.4.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The property or indexer cannot be used in this context because the set accessor is inaccessible"
3 participants