New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Immutable dictionaries #351
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 91.71% 92.08% +0.37%
==========================================
Files 109 122 +13
Lines 3379 3866 +487
Branches 438 526 +88
==========================================
+ Hits 3099 3560 +461
- Misses 189 207 +18
- Partials 91 99 +8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbebda9
to
e01a6ec
Compare
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/Mappings/LinqDictionaryMapping.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/Mappings/LinqDictionaryMapping.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/Mappings/LinqDictionaryMapping.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
96e604c
to
8c78245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
Sorry for the late feedback. 2-3 smaller points to discuss / fix, otherwise it looks really good to me 😊
Could you then also rebase (I think there may be some conflicts 🤔) and squash into one feature commit? Thanks!
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
07cd05d
to
96df8e1
Compare
76ae6aa
to
6fed80e
Compare
🎉 This PR is included in version 2.8.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Resolve the last two types from #250
ImmutableDictionary
andImmutableSortedDictionary
DictionaryMappingBuilder
to prevent existing immutable types from being assigned to in a foreach loop. - I did not copy the approach of checking for a implicit setter from the Immutable Enumerable types as this would conflict with fix: Insert a cast toIDictionary
when an explicit setter is present #341.