Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: directly assign System.Uri and System.Version when deep cloning #440

Merged

Conversation

latonz
Copy link
Contributor

@latonz latonz commented May 17, 2023

Closes #438
Closes #437

@latonz latonz requested a review from CommonGuy May 17, 2023 13:14
@latonz latonz self-assigned this May 17, 2023
@latonz latonz enabled auto-merge (squash) May 17, 2023 13:15
Since System.Uri and System.Version are immutable, these can be directly assigned even if deep cloning is enabled
@latonz latonz force-pushed the 438-support-deep-cloning-of-immutable-types branch from 6a36c87 to d4e8b29 Compare May 17, 2023 13:19
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #440 (d4e8b29) into main (b17f666) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   92.08%   92.21%   +0.13%     
==========================================
  Files         135      135              
  Lines        4282     4293      +11     
  Branches      591      590       -1     
==========================================
+ Hits         3943     3959      +16     
+ Misses        225      223       -2     
+ Partials      114      111       -3     
Impacted Files Coverage Δ
...iptors/MappingBuilders/EnumerableMappingBuilder.cs 97.57% <100.00%> (+3.06%) ⬆️
...Mapperly/Descriptors/UserMethodMappingExtractor.cs 92.98% <100.00%> (+0.04%) ⬆️
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 89.47% <100.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz merged commit c845b43 into riok:main May 17, 2023
14 checks passed
@latonz latonz deleted the 438-support-deep-cloning-of-immutable-types branch May 17, 2023 13:27
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special case deep cloning for System.Version Special case deep cloning for System.Uri
2 participants