Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow reference handling for generic and runtime target type map… #508

Merged
merged 1 commit into from Jun 20, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jun 19, 2023

Closes #465

@latonz latonz self-assigned this Jun 19, 2023
@latonz latonz force-pushed the 465-reference-handling-generic branch from 15079d1 to 3c8b0a2 Compare June 19, 2023 17:03
@latonz latonz marked this pull request as ready for review June 19, 2023 17:04
@latonz latonz force-pushed the 465-reference-handling-generic branch from 3c8b0a2 to f919d8d Compare June 19, 2023 17:06
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #508 (f919d8d) into main (85347e4) will increase coverage by 0.23%.
The diff coverage is 95.08%.

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   91.96%   92.20%   +0.23%     
==========================================
  Files         147      150       +3     
  Lines        4656     4808     +152     
  Branches      588      611      +23     
==========================================
+ Hits         4282     4433     +151     
- Misses        254      255       +1     
  Partials      120      120              
Impacted Files Coverage Δ
src/Riok.Mapperly/Descriptors/WellKnownTypes.cs 88.88% <ø> (ø)
...numerables/EnsureCapacity/EnsureCapacityBuilder.cs 77.77% <80.00%> (-0.49%) ⬇️
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 93.16% <83.33%> (+1.85%) ⬆️
...iptors/MappingBuilders/DictionaryMappingBuilder.cs 90.98% <88.23%> (+4.02%) ⬆️
...iptors/MappingBuilders/EnumerableMappingBuilder.cs 94.66% <91.37%> (-3.01%) ⬇️
...Mapperly/Descriptors/Enumerables/CollectionInfo.cs 94.28% <94.28%> (ø)
...y/Descriptors/Enumerables/CollectionInfoBuilder.cs 96.42% <96.42%> (ø)
...apperly/Descriptors/Enumerables/CollectionInfos.cs 100.00% <100.00%> (ø)
...odyBuilders/RuntimeTargetTypeMappingBodyBuilder.cs 100.00% <100.00%> (ø)
...Riok.Mapperly/Descriptors/MappingBuilderContext.cs 98.14% <100.00%> (+0.03%) ⬆️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz requested a review from CommonGuy June 19, 2023 17:16
@latonz latonz enabled auto-merge (squash) June 19, 2023 17:26
@latonz latonz merged commit 34b237f into riok:main Jun 20, 2023
14 checks passed
@latonz latonz deleted the 465-reference-handling-generic branch June 20, 2023 05:48
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference handling with generic and runtime target type mappings
2 participants