Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map nullable value types correct to user implemented method arguments #64

Merged
merged 1 commit into from Apr 5, 2022

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Apr 5, 2022

Remove duplicated nullable object property tests

@latonz latonz added the bug Something isn't working label Apr 5, 2022
@latonz latonz requested a review from CommonGuy April 5, 2022 12:38
@latonz latonz self-assigned this Apr 5, 2022
…ments

Remove duplicated nullable object property tests
@latonz latonz force-pushed the 63-nullable-value-type-properties branch from 2c7efb2 to a5ddf71 Compare April 5, 2022 12:41
@latonz latonz linked an issue Apr 5, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #64 (a5ddf71) into main (3153028) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   89.32%   89.34%   +0.01%     
==========================================
  Files          72       72              
  Lines        2324     2327       +3     
  Branches      299      299              
==========================================
+ Hits         2076     2079       +3     
  Misses        182      182              
  Partials       66       66              
Impacted Files Coverage Δ
...ors/MappingBuilder/ObjectPropertyMappingBuilder.cs 100.00% <100.00%> (ø)
...ptors/Mappings/PropertyMappings/PropertyMapping.cs 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@latonz latonz marked this pull request as ready for review April 5, 2022 12:51
@CommonGuy CommonGuy merged commit 073eb17 into main Apr 5, 2022
@CommonGuy CommonGuy deleted the 63-nullable-value-type-properties branch April 5, 2022 12:52
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping from double? to complex type generates wrong code
3 participants