Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowMultiple into MapEnumValueAttribute #672

Merged
merged 1 commit into from Aug 23, 2023

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Aug 22, 2023

MapEnumValueAttribute is missing AttributeUsageAttribute(AllowMultiple=true)

When you want to specify multiple MapEnumValueAttribute you are not allowed by compiler

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@trejjam trejjam force-pushed the feature/multiple-map-enum-value branch from 324af53 to a1b87cd Compare August 22, 2023 13:11
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #672 (d121867) into main (a5f6aef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         172      172           
  Lines        6130     6130           
  Branches      780      780           
=======================================
  Hits         5577     5577           
  Misses        377      377           
  Partials      176      176           
Files Changed Coverage Δ
...iok.Mapperly.Abstractions/MapEnumValueAttribute.cs 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@trejjam trejjam force-pushed the feature/multiple-map-enum-value branch from a1b87cd to 17c37b7 Compare August 22, 2023 15:35
@trejjam trejjam force-pushed the feature/multiple-map-enum-value branch from 17c37b7 to d121867 Compare August 22, 2023 15:42
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, lgtm 😊

@latonz latonz merged commit 71cbfdd into riok:main Aug 23, 2023
17 checks passed
@trejjam trejjam deleted the feature/multiple-map-enum-value branch August 24, 2023 21:34
@github-actions
Copy link

🎉 This PR is included in version 3.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants