New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate diagnostic warning when ignored members are explicitly mapped #708
feat: generate diagnostic warning when ignored members are explicitly mapped #708
Conversation
56592a5
to
9c66379
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to Mapperly 😊
I added some feedback, feel free to discuss the feedback provided or ask questions if sth. is not clear.
Since this is your first contribution I need to manually approve the CI run each time you contribute, I'll try to do this as fast as I can so that fast feedback is provided to you. However, if it is still too slow, you can create a PR against your own fork.
...Riok.Mapperly/Descriptors/MappingBodyBuilders/BuilderContext/MembersMappingBuilderContext.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 91.15% 91.21% +0.05%
==========================================
Files 198 198
Lines 6557 6601 +44
Branches 816 820 +4
==========================================
+ Hits 5977 6021 +44
Misses 389 389
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
87addb2
to
de29460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, lgtm 😊
🎉 This PR is included in version 3.2.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Add a diagnostic if an explicitly ignored member is mapped explicitly
Description
Ignored members could also be explicitly mapped, but this may not be intended. This change adds warning level diagnostic messages when either a source or a target member is in that situation, but should not alter the behaviour of the library.
Fixes #512 (using the approach specified in its description)
Checklist