Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unmapped source property diagnostic #77

Merged
merged 1 commit into from May 16, 2022
Merged

Conversation

latonz
Copy link
Contributor

@latonz latonz commented May 16, 2022

New diagnostic RMG020 Source property is not mapped to any target property which allows to configure a strict mapping mode

@latonz latonz self-assigned this May 16, 2022
@latonz latonz added the enhancement New feature or request label May 16, 2022
@latonz latonz requested a review from CommonGuy May 16, 2022 07:06
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #77 (bec3b48) into main (e8351f1) will increase coverage by 0.19%.
The diff coverage is 98.36%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   89.44%   89.63%   +0.19%     
==========================================
  Files          73       74       +1     
  Lines        2368     2412      +44     
  Branches      304      305       +1     
==========================================
+ Hits         2118     2162      +44     
  Misses        183      183              
  Partials       67       67              
Impacted Files Coverage Δ
...gs/PropertyMappings/ConstructorParameterMapping.cs 58.53% <83.33%> (+1.03%) ⬆️
...MappingBuilder/NewInstanceMappingBuilderContext.cs 100.00% <100.00%> (ø)
...Builder/NewInstanceObjectPropertyMappingBuilder.cs 85.09% <100.00%> (ø)
...ors/MappingBuilder/ObjectPropertyMappingBuilder.cs 100.00% <100.00%> (ø)
...pingBuilder/ObjectPropertyMappingBuilderContext.cs 100.00% <100.00%> (ø)
...Riok.Mapperly/Diagnostics/DiagnosticDescriptors.cs 100.00% <100.00%> (ø)
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 95.12% <100.00%> (+1.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

New diagnostic RMG020 Source property is not mapped to any target property which allows to configure a strict mapping mode
@latonz latonz linked an issue May 16, 2022 that may be closed by this pull request
@CommonGuy CommonGuy merged commit 68236ba into main May 16, 2022
@CommonGuy CommonGuy deleted the 68-strict-mode branch May 16, 2022 12:24
@github-actions
Copy link

🎉 This PR is included in version 2.3.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict mode
3 participants