feat: add diagnostic for nested ignores #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
==========================================
+ Coverage 91.35% 91.38% +0.03%
==========================================
Files 202 202
Lines 6697 6721 +24
Branches 830 832 +2
==========================================
+ Hits 6118 6142 +24
Misses 388 388
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
latonz
requested changes
Oct 16, 2023
...Riok.Mapperly/Descriptors/MappingBodyBuilders/BuilderContext/MembersMappingBuilderContext.cs
Outdated
Show resolved
Hide resolved
...Riok.Mapperly/Descriptors/MappingBodyBuilders/BuilderContext/MembersMappingBuilderContext.cs
Show resolved
Hide resolved
TimothyMakkison
force-pushed
the
nested_ignore
branch
3 times, most recently
from
32d0425
to
f84bf71
Compare
latonz
approved these changes
Oct 18, 2023
latonz
requested changes
Oct 18, 2023
TimothyMakkison
force-pushed
the
nested_ignore
branch
from
744c8df
to
7315c57
Compare
latonz
approved these changes
Oct 20, 2023
|
🎉 This PR is included in version 3.3.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagnostic for nested ignores
Description
Mapperly does not support nested ignores. To prevent confusion, I've added 2 diagnostics that will warn the user when one is found.
IgnoredTargetMemberNotFound/IgnoredSourceMemberNotFounddiagnostics will not be emitted.Fixes #815, #814
Checklist