Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obsolete constructors should have the last priority whlie matching constructors (regression) #898

Merged
merged 1 commit into from Nov 14, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Nov 14, 2023

Fixes #893

@latonz latonz self-assigned this Nov 14, 2023
@latonz latonz requested a review from ni507 November 14, 2023 12:50
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cceb6d) 91.36% compared to head (2c2f77f) 91.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         214      214           
  Lines        7159     7159           
  Branches      869      869           
=======================================
  Hits         6541     6541           
  Misses        411      411           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz enabled auto-merge (squash) November 14, 2023 12:56
@latonz latonz merged commit 20b7da6 into riok:main Nov 14, 2023
19 checks passed
@latonz latonz deleted the 893 branch November 14, 2023 12:57
Copy link

🎉 This PR is included in version 3.3.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: obsolete constructors are not considered last
2 participants