fix: improve location of reported diagnostics #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
force-pushed
the
896-appropriate-diagnostic-location
branch
from
88e3e42
to
806852b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 91.27% 91.23% -0.05%
==========================================
Files 221 222 +1
Lines 7074 7085 +11
Branches 886 895 +9
==========================================
+ Hits 6457 6464 +7
- Misses 410 411 +1
- Partials 207 210 +3 ☔ View full report in Codecov by Sentry. |
latonz
force-pushed
the
896-appropriate-diagnostic-location
branch
4 times, most recently
from
d5e991e
to
cf13a00
Compare
Use more accurate location for reported diagnostics. Fallback to mapper class is used a lot less. For nested mappings the last user defined mapping method is used instead. For attributes the attribute syntax is used.
latonz
force-pushed
the
896-appropriate-diagnostic-location
branch
from
cf13a00
to
589ca19
Compare
ni507
approved these changes
Nov 23, 2023
|
🎉 This PR is included in version 3.3.0-next.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve location of reported diagnostics
Description
Use more accurate location for reported diagnostics.
Fallback to mapper class is used a lot less.
For nested mappings the last user defined mapping method is used instead.
For attributes the attribute syntax is used.
Fixes #896
Checklist