Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core sublibrary clashes with core alternate standard library #19

Open
roddyyaga opened this issue Dec 21, 2023 · 5 comments
Open

core sublibrary clashes with core alternate standard library #19

roddyyaga opened this issue Dec 21, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@roddyyaga
Copy link

Hey, I'm running into problems using this in a project that also depends on https://github.com/janestreet/core (inconsistent assumptions over interface for Core__Ref). Changing the riot files to reference riot.core doesn't fix this.

Could this be renamed to riot_core or something? That's how I fixed it locally. Possibly this is a bug in dune (I vaguely thought this was supposed to work), but even if it is I guess the fix for that will take a while, so it would be nice to fix it in riot.

@leostera
Copy link
Collaborator

Thanks for flagging this! 👍🏼 I'll look at how to hide those libs, this stuff should be contained in the Riot.Runtime module.

@leostera
Copy link
Collaborator

Incoming fix! 🚀 This should fix it: 329b093 – could you pin it locally and let me know if it solves your issue?

@leostera leostera added the bug Something isn't working label Dec 21, 2023
@leostera
Copy link
Collaborator

@roddyyaga did this fix it for you?

@FraMecca
Copy link

I get this with riot 0.0.8

File "bin/amq.ml", line 1:          
Error: The files /home/user/.opam/5.1.1/lib/async/async.cmi
       and bin/.main.eobjs/byte/dune__exe__Datatypes.cmi
       make inconsistent assumptions over interface Core
Had 1 error, waiting for filesystem changes...


@leostera leostera added this to the riot/phase-1 milestone Mar 18, 2024
@leostera
Copy link
Collaborator

As per @anmonteiro's suggestion we should try using (include_subdirs qualified) at the riot/runtime level to just ship a single library for the whole runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants