Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make match%b expressions tail-recursive #49

Open
leostera opened this issue Jan 24, 2024 · 0 comments
Open

Make match%b expressions tail-recursive #49

leostera opened this issue Jan 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@leostera
Copy link
Collaborator

currently when we write a recursive function that uses a match%b expression to pattern-match on bytestrings, we end up creating a stack, instead of tail-recursing.

My gut tells me this is the try-catches we have, and we may want to move to a result-based error-recovery pattern.

For example, i'd expect this function to be tail recursive, but it isn't:

let rec split ?(left = {%b||}) str =
  match%b str with
  | {| "\r\n"::bytes, rest::bytes |} -> [ left; rest ]
  | {| c::utf8, rest::bytes |} -> split ~left:(Bytestring.join c left) rest
@leostera leostera added the bug Something isn't working label Jan 24, 2024
@leostera leostera added this to the riot/phase-2 milestone Mar 2, 2024
@leostera leostera removed this from the riot/phase-2 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant