Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this module be split from the riot core? #1

Closed
GianlucaGuarini opened this issue Sep 11, 2015 · 6 comments
Closed

Should this module be split from the riot core? #1

GianlucaGuarini opened this issue Sep 11, 2015 · 6 comments

Comments

@GianlucaGuarini
Copy link
Member

I am still not sure whether this module should still be included in the main riot repo or just installable via npm riot-cli. I would like to know your opinion on this topic

cc @tipiirai @cognitom @aMarCruz @rsbondi

@GianlucaGuarini GianlucaGuarini changed the title Should this mudule be split from the riot core? Should this module be split from the riot core? Sep 11, 2015
@cognitom
Copy link
Member

Both is reasonable for me. Basically I have no preference about it, but I like the idea riot-cli. It looks cleaner.

@aMarCruz
Copy link

Sorry @GianlucaGuarini , having very busy days, but I'm back :)
I think this is part of the compiler, and should be with him.

@GianlucaGuarini
Copy link
Member Author

@aMarCruz welcome back.. I am happy to receive your feedback again!
My idea was to rely on the riot-compiler but I would avoid that riot and riot-compiler load these dependencies.
Let's use them just in this repo

@aMarCruz
Copy link

ok, why not integrate riot-cli in riot-compiler ? I'm not sure, but I think is the standard way in npm packages.

@GianlucaGuarini
Copy link
Member Author

@aMarCruz this would mean that anytime someone will install the riot-compiler in a project he/she will load and install dependencies to compile the tags via command line even if he/she doesn't need it. I would prefer to split them also to get a cleaner unit test (target tags and expected fixtures), but that's more my opinion. I would like to know also what @tipiirai thinks about this

@tipiirai
Copy link

I think anything goes as long as users can compile riot tags after the npm install riot command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants