Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot foo/bar baz.js does not handle symlinks in foo/bar #14

Closed
juodumas opened this issue May 3, 2016 · 3 comments
Closed

riot foo/bar baz.js does not handle symlinks in foo/bar #14

juodumas opened this issue May 3, 2016 · 3 comments

Comments

@juodumas
Copy link

juodumas commented May 3, 2016

riot foo/bar baz.js does not handle symlinks in foo/bar because shelljs.find() does not dive into symlinked directories ( https://github.com/riot/cli/blob/master/lib/helpers.js#L20). It would be nice if it did.

@GianlucaGuarini
Copy link
Member

I will update shelljs on the next release hoping they have fixed this issue that is not riot specific. Thanks for pointing this out

@juodumas
Copy link
Author

juodumas commented May 3, 2016

Just checked, it's working with shelljs@0.7.0 and currently you have
0.6.0.

Took a look at their repo, looks like they have some breaking changes:
https://github.com/shelljs/shelljs/wiki/Migrating-from-v0.6-to-v0.7

Thanks.

@GianlucaGuarini
Copy link
Member

fixed in riot-cli@2.5.0 thanks for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants