Compiler preserves newlines in class objects, causing Unterminated String Constant errors

[klardotsh]

Given a tag consisting of the following:

<so-input>
    <label if={ opts.label } for="theInput">{ opts.label }</label>
    <input id="theInput"
        class={
            'is-invalid': note.type === 1,
            'is-valid': ofMinLength && note.type !== 1
        }>

    <script>
        require('./so-input.js').call(this);
    </script>
</so-input>

Which validates through $(npm bin)/riot --check so-input.tag --type es6

The compiled output will consist of the following, which contains an Unterminated String Constant at the end of Line 1 (which will break our Webpack build)

riot.tag2('so-input', '<label if="{opts.label}" for="theInput">{opts.label}</label> <input id="theInput" class="{\'is-invalid\': note.type === 1,
            \'is-valid\': ofMinLength && note.type !== 1}">', '', '', function(opts) {
require('./so-input.js').call(this);
}, '{ }');

By moving the class definitions to a single line, the compiler will output valid JS:

<so-input>
    <label if={ opts.label } for="theInput">{ opts.label }</label>
    <input id="theInput"
        class={'is-invalid': note.type === 1, 'is-valid': ofMinLength && note.type !== 1}>

    <script>
        require('./so-input.js').call(this);
    </script>
</so-input>

riot.tag2('so-input', '<label if="{opts.label}" for="theInput">{opts.label}</label> <input id="theInput" class="{\'is-invalid\': note.type === 1, \'is-valid\': ofMinLength && note.type !== 1}">', '', '', function(opts) {
require('./so-input.js').call(this);
}, '{ }');

The newlines should either be stripped, or a closing quote and + operator (to concat with the string on the next line) should be inserted.

[GianlucaGuarini]

@aMarCruz Is something you could check before releasing the 2.3.0 release?

[aMarCruz]

I will check this

[klardotsh]

Any updates in this regard? I know you guys have been busy with releases, but curious anyway :)

[aMarCruz]

please test with riot-compiler v2.3.1, it is fixed