[2.3.0] settings.brackets no longer works

[nippur72]

There are two issues with settings.brackets:

First:

riot.settings.brackets = "{{ }}";
var compiled = riot.compile("<my>{{time}} and {time}</my>",true);

results in no difference between the two "time"s:

compiled == "riot.tag2('my', '{time} and {time}', '', '', function(opts) {\n}, '{ }');"

Second issue is that there is still reference to settings.brackets somewhere in riot's code making it throw a lot of errors when I use custom brackets. The only way to make it work is to restore riot's default bracketing:

riot.settings.brackets = "{{ }}";
// tag registration here
riot.settings.brackets = "{ }";  // restores back riot's default brackets

[GianlucaGuarini]

this is a bug @aMarCruz I have assigned it to you. Please let me know if we could solve it easily

[aMarCruz]

I'll review this.

[aMarCruz]

@nippur72 , I'm working in the fix.
For now, please use only the riot.util.brackets.set, parameter is the same as the value for riot.settings.brackets:
riot.util.brackets.set('{{ }}')
riot.util.brackets.set() or riot.util.brackets.set(null) reset brackets to default.

[aMarCruz]

@GianlucaGuarini , I fixed this and other bug with tmpl.loopKeys, and its tests, in the dev branch of tmpl. The first bug is in the interaction of the compiler, brackets, and riot.compile when used riot.settings.brackets, the second is in the regexp for loopKeys not recognizing custom brackets.

I send a PR for riot in bug/1314 branch with a test for the first use (needs the dev version of tmpl).

btw: There are another (old) issue I found when changing brackets with the same expression: riot/tmpl#9; locking the brackets avoids the error, but I think this is not a priority.

[aMarCruz]

This issue is fixed in the riot-compiler repository, it is not updated in npm yet.