Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyone working on this? switch from makefile to a more crossplatform solution #2024

Closed
vitogit opened this issue Oct 13, 2016 · 11 comments
Closed

Comments

@vitogit
Copy link
Contributor

vitogit commented Oct 13, 2016

The 3.0 roadmap say: switch from makefile to a more crossplatform solution

Anyone working on it?
I have some code using cross-env (for compatibility) and package.json to run the current tests. I don´t test it in windows yet.

But not sure what´s the scope of this issue, and if someone else has other ideas.
-should we support Windows for every task?
-should we support integration with Travis?
-should we use other tools? rollup, webpack?

Here are my changes https://github.com/vitogit/riot/compare/next...vitogit:vitomd_next?expand=1

  1. How would you tag this issue?
    • [x ] Question
@aMarCruz
Copy link
Contributor

We must support Windows 7+cmd in all tasks, I think this will be integrated in the final phase of v3 with a setup very close to yours.

@vitogit
Copy link
Contributor Author

vitogit commented Oct 14, 2016

@aMarCruz Is there anyone in charge of that? or Are new prs welcome for this feature?

@aMarCruz
Copy link
Contributor

@vitogit , prs are welcome of course, current I'm working only in riot-tmpl.

@GianlucaGuarini
Copy link
Member

@aMarCruz I think now the prio is on riot/compiler#56, when the compiler will be refactored we will be able to release riot@3.0.0 - for me makefile or gulpfile does make any difference

@vitogit
Copy link
Contributor Author

vitogit commented Oct 14, 2016

It would be nice to know what tasks are currently being working on and who are working on them. I know that there is the Project tab but I´m not sure who is working on each issue.
The compiler is being refactored because the source maps? or there are other changes as well?

@aMarCruz
Copy link
Contributor

aMarCruz commented Oct 15, 2016

@vitogit yes, source maps is the reason.
This is not easy with regexes, so I'm working in a new (lightweight) parser that can handle HTML and JS, including the untagged JS block, new ES6 template literals, and don't crash with the various JS dialects supported by riot. There's no parser in the npm universe that does this work.

@aMarCruz
Copy link
Contributor

aMarCruz commented Oct 15, 2016

@GianlucaGuarini btw, I have an almost working proto, the hard part is the expressions. I'm very busy again but I will try to upload the branch in next days.
Also, it requires heavy changes to riot.tag2 to allow hot-reloading as this needs link expression and css to the tag definition.

@GianlucaGuarini
Copy link
Member

I am a bit skeptical polluting our package.json file with other npm devDependencies to achieve stuff that could be simply done with a couple of native cli commands. Isn't there another simpler solution? I would like to avoid to download the whole internet for something we could do with mkdir or cp... probably we could use js and shelljs?!

@vitogit
Copy link
Contributor Author

vitogit commented Oct 16, 2016

I don't have much experience with shelljs. Seems like a good solution, but I found that they deprecated the shelljs/make and then revert it, but seems like they want to remove it in the future
shelljs/shelljs#458
airporad said this:
we've decided that this till will be unsupported going forward, so we're going to say something along those lines.

@GianlucaGuarini GianlucaGuarini mentioned this issue Nov 14, 2016
16 tasks
@cognitom
Copy link
Member

I prefer npm scripts, as @vitogit shown at the first of this thread. Now there's no need to use Makefile.
90% of the code could move to npm scripts, the left 10% could move to independent shell file, I think.

FYI, we can use variables in package.json: $npm_package_dist or something.
http://ianmcnally.me/blog/2016/2/4/variables-in-npm-scripts

@GianlucaGuarini
Copy link
Member

Closing this issue due to inactivity I am happy with the current make file. I will eventually accept pull requests but my focus is definitely not on this issue at moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants