Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef::Artifact.get_current_deployed_version will be true even when you delete whats being symlinked to #81

Open
KAllan357 opened this issue Jul 10, 2013 · 2 comments

Comments

@KAllan357
Copy link
Contributor

Should check the symlink that there are files beneath it.

https://github.com/RiotGames/artifact-cookbook/blob/master/libraries/chef_artifact.rb#L276-L278

@logikal
Copy link

logikal commented Jul 22, 2013

This is similar to CHEF-1162, which is fixed in 11.6.0 (chef/chef#814).
Would love to have artifact_deploy match how revision_deploy handles this.

@KAllan357
Copy link
Contributor Author

I'm not entirely sure how the pull being referenced here fixes this issue, but I do agree that this should be fixed!

If we'd want our code to be as similar to this Chef code as possible, it seems like we might need to implement some sort of JSON file to handle the status of the files? That might be a rather large change, so at the moment I'm leaning towards just fixing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants