Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using arrow keys for skipping forward and backwards is slightly broken #3

Closed
hopto-dot opened this issue Apr 7, 2021 · 4 comments
Closed
Labels
wontfix This will not be worked on

Comments

@hopto-dot
Copy link

Upon pressing either of the left/right arrow keys the video goes forwards or backwards twice, aka 10 seconds rather than 5.

Rather than fixing it so it goes forward once I think it would be better to skip to the previous or next subtitle, to add to this, also have the enter key replay the current subtitle.

@ripose-jp
Copy link
Owner

ripose-jp commented Apr 7, 2021

Nice catch with the double seek, I'll fix it in the next release.

As for changing the default keybinds, I'd rather not so Memento remains functionally as close to mpv as possible.

You can implement the behavior you want pretty easily by adding these lines to your input.conf.

ENTER   sub-seek        0
RIGHT   sub-seek        1
LEFT    sub-seek        -1

Check the README to find the location of the config directory for your operating system.

These links will be helpful for finding out what the default binds are and how to configure you own custom binds:
https://mpv.io/manual/stable/
https://github.com/mpv-player/mpv/blob/master/etc/input.conf

@hopto-dot
Copy link
Author

hopto-dot commented Apr 7, 2021

Wow, thank you! This is amazing, I didn't know about this.

@ripose-jp
Copy link
Owner

I've done a little poking around and found out the "double seek" thing is actually default mpv behavior.

mpv has two ways of handling seeks, approximate seeks and exact seeks. An approximate seek just seeks to the next highest value of 10. For example, RIGHT seek 1 will seek 10 seconds ahead, while RIGHT seek 11 will seek 20 seconds ahead. You can request mpv do exact seeks for everything by setting hr-seek=yes in your mpv.conf file, or by binding an exact seek like RIGHT seek 5 exact in your input.conf.

I'm not sure whether or not I'll change this behavior in the next release. Until I decide, I'll leave this issue open.

@ripose-jp
Copy link
Owner

I've decided to leave the the seeking behavior the way it is since

  • it's intended mpv behavior
  • users can change the behavior themselves
  • hard coding hr-seek=yes takes away configuration options
  • it may potentially make the player perform worse on lower end hardware

@ripose-jp ripose-jp added the wontfix This will not be worked on label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants