Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line arguments don't work from AppImage #130

Closed
cessen opened this issue Nov 6, 2022 · 2 comments
Closed

Command line arguments don't work from AppImage #130

cessen opened this issue Nov 6, 2022 · 2 comments
Labels
invalid This doesn't seem right linux This only occurs on Linux

Comments

@cessen
Copy link

cessen commented Nov 6, 2022

(First of all: thanks so much for building and maintaining this awesome tool!)

I usually start video players like mpv from either the command line directly, or via scripts hooked up to custom menus in my file browser. However, the AppImage build of Memento seems to ignore any command line arguments passed to it. For example:

$ Memento_Linux_x86_64.AppImage path/to/some/video.mkv

Just launches Memento with no file loaded, whereas I would expect it to launch and play the passed file. This isn't a deal breaker or anything, since I can just drag files/folders into memento instead. But it does make things a little awkward.

@ripose-jp ripose-jp added the linux This only occurs on Linux label Nov 6, 2022
@ripose-jp
Copy link
Owner

I hate to say this, but it works on my machine. Do you have xdg-open installed?

@cessen
Copy link
Author

cessen commented Nov 6, 2022

Gah! This was my bad. The combination of there being no --help and things not working when I was passing file paths inside a shell script made me think no arguments were getting through.

Turns out they were getting through, but I was passing them via $@ instead of "$@", which made files with spaces in the names not work (through no fault of Memento).

You might consider adding a minimal --help response, where it just prints a message and exits. I—and I suspect others—use that not only to get help but also to check if the software is responding correctly from the command line.

Anyway, sorry for the false report!

@cessen cessen closed this as completed Nov 6, 2022
@ripose-jp ripose-jp added the invalid This doesn't seem right label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right linux This only occurs on Linux
Projects
None yet
Development

No branches or pull requests

2 participants