Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate card logic has false positives with pure hiragana words #151

Closed
stephen-huan opened this issue Mar 13, 2023 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@stephen-huan
Copy link

If one has a pure hiragana word in their deck, for example, なんか, then
memento will think that it is a card for any expression with the reading
なんか. In particular, this includes words like 軟化, 何か, 南下, 軟貨, 難化
just to list a few which have completely different meanings.

The way to tell they're marked as duplicates is that the "+" sign turns
into a hamburger menu (the icon with 3 lines) and clicking on the
icon searches for something like "軟化 OR なんか" in the deck.

Based on this, my guess is that memento will try substituting both
the original kanji expression as well as the hiragana reading for
the {expression} value and consider a card present in the deck
already if either of these possible substitutions are in the deck.

I find this behavior a bit odd, in particular, yomichan does not do this.
For words that can be written not in hiragana it's possible to circumvent
this issue by simply using the non-pure hiragana writing but for a word
like なんか there simply isn't an alternative writing.

It's possible the issue is just with my particular memento configuration
through anki_connect.json. If it isn't just a configuration issue,
I'd suggest including a configuration option along the lines of
"de-duplicate cards based on reading" or something along those lines.

@ripose-jp ripose-jp added the bug Something isn't working label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants