make orderbook use Remote.getLedgerSequenceSync

fix some variables naming in src/api

src/api/ledger/transaction.js

@@ -91,18 +91,17 @@ function getTransactionAsync(identifier: string, options: TransactionOptions,
 
 
   function maxLedgerGetter(error_?: Error, tx?: Object) {
-    remote.getLedgerSequence(function(err?, seq: number) {
-      _.noop(err);
-      const maxLedgerVersion = options.maxLedgerVersion || seq;
+    this.getLedgerVersion().then((version) => {
+      const maxLedgerVersion = options.maxLedgerVersion || version;
       callbackWrapper(error_, tx, maxLedgerVersion);
-    });
+    }, callbackWrapper);
   }
 
   async.waterfall([
     _.partial(remote.requestTx.bind(remote),
       {hash: identifier, binary: false}),
     _.partial(attachTransactionDate, remote)
-  ], maxLedgerGetter);
+  ], maxLedgerGetter.bind(this));
 }
 
 function getTransaction(identifier: string,

src/api/ledger/utils.js

@@ -120,10 +120,9 @@ function getLedgerOptionsWithLedgerVersion(account: string, options: Object,
   ) {
     callback(null, account, options);
   } else {
-    this.remote.getLedgerSequence(common.convertErrors((err, sequence) => {
-      callback(err, account, _.assign({}, options, {
-        ledgerVersion: sequence}));
-    }));
+    this.getLedgerVersion().then((version) => {
+      callback(null, account, _.assign({}, options, {ledgerVersion: version}));
+    }, callback);
   }
 }
 

src/api/transaction/utils.js

@@ -59,8 +59,8 @@ function prepareTransaction(transaction: any, remote: any, instructions: any,
     } else {
       const offset = instructions.maxLedgerVersionOffset !== undefined ?
         parseInt(instructions.maxLedgerVersionOffset, 10) : 3;
-      remote.getLedgerSequence((error, seq) => {
-        txJSON.LastLedgerSequence = seq + offset;
+      remote.getLedgerSequence((error, ledgerVersion) => {
+        txJSON.LastLedgerSequence = ledgerVersion + offset;
         callback_(error);
       });
     }

src/core/orderbook.js

@@ -846,7 +846,7 @@ OrderBook.prototype.onTransaction = function(transaction) {
 
 
   if (--this._transactionsLeft === 0 && !this._waitingForOffers) {
-    const lastClosedLedger = this._remote.getLedgerSequence();
+    const lastClosedLedger = this._remote.getLedgerSequenceSync();
     if (this._isAutobridgeable) {
       if (this._canRunAutobridgeCalc()) {
         if (this._legOneBook._lastUpdateLedgerSequence === lastClosedLedger ||
@@ -1080,7 +1080,7 @@ OrderBook.prototype.notify = function(transaction) {
 
   this.emit('transaction', transaction);
 
-  this._lastUpdateLedgerSequence = this._remote.getLedgerSequence();
+  this._lastUpdateLedgerSequence = this._remote.getLedgerSequenceSync();
 
   if (!takerGetsTotal.is_zero()) {
     this.emit('trade', takerPaysTotal, takerGetsTotal);