Prevent prepareTransaction from overwriting values in txJSON #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
force-pushed
the
fix-prepareTransaction
branch
from
1c3073d
to
2a6ebc7
Compare
jwbusch
approved these changes
Apr 12, 2019
| const disallowedFieldsInTxJSON = ['maxLedgerVersion', 'maxLedgerVersionOffset', 'fee', 'sequence'] | ||
| const badFields = disallowedFieldsInTxJSON.filter(field => txJSON[field]) | ||
| if (badFields.length) { | ||
| return Promise.reject(new ValidationError('txJSON additionalProperty "' + badFields[0] + |
There was a problem hiding this comment.
nit: this only returns the first invalid error, could include all of the bad fields.
There was a problem hiding this comment.
👍 Thanks! I think it'll be rare for someone to use multiple bad fields and if they do, it's still OK to point them out one by one.
mDuo13
approved these changes
Apr 13, 2019
src/transaction/utils.ts
Outdated
| // instructions.maxLedgerVersionOffset | ||
| if (txJSON.LastLedgerSequence && instructions.maxLedgerVersion) { | ||
| return Promise.reject(new ValidationError('`LastLedgerSequence` in txJSON and `maxLedgerVersion`' + | ||
| ' in Instructions cannot both be set')) |
There was a problem hiding this comment.
nit: I suggest writing `instructions` rather than Instructions, to be consistent with how the other parts are written
src/transaction/utils.ts
Outdated
| } | ||
| if (txJSON.LastLedgerSequence && instructions.maxLedgerVersionOffset) { | ||
| return Promise.reject(new ValidationError('`LastLedgerSequence` in txJSON and `maxLedgerVersionOffset`' + | ||
| ' in Instructions cannot both be set')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #997