Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package.json] Require node 8 and yarn #1107

Merged
merged 2 commits into from Dec 11, 2019
Merged

[package.json] Require node 8 and yarn #1107

merged 2 commits into from Dec 11, 2019

Conversation

intelliot
Copy link
Collaborator

This library should be used with node 8 and yarn

@intelliot
Copy link
Collaborator Author

@tylerlevine I guess this would remove node 6 support, right? If that's the case I'm ok with leaving this alone for now. #1070 (comment)

@tylerlevine
Copy link
Contributor

@tylerlevine I guess this would remove node 6 support, right? If that's the case I'm ok with leaving this alone for now. #1070 (comment)

Not directly, we can still use --ignore-engines to get an install working there. We actually already do this for other reasons for node 6, so this shouldn't affect us.

In other news, we should be dropping node 6 completely by the end of the year.

Copy link
Contributor

@0xCLARITY 0xCLARITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelliot intelliot merged commit c88462c into develop Dec 11, 2019
@intelliot intelliot deleted the update-engines branch December 11, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants