Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Filtering source_amount pathfind correctly #707

Merged
merged 1 commit into from Mar 21, 2016

Conversation

alandotcom
Copy link
Contributor

Bug:

api.connect().then(() => {
  const pathfind = {
    source: {
      address: USDCold,
      amount: {
        currency: 'USD',
        value: '1.00' // <<<< Rippled response has "1" not "1.00"
      }
    },
    destination: {
      address: EURCold,
      amount: {currency: 'EUR'}
    }
  };
  return api.getPaths(pathfind).then(paths => {
    console.log('PATHS: \n', JSON.stringify(paths, null, 2));
  });
}).catch(console.log);

@alandotcom
Copy link
Contributor Author

Working on a unit test

Bug:

```js
api.connect().then(() => {
  const pathfind = {
    source: {
      address: USDCold,
      amount: {
        currency: 'USD',
        value: '1.00' // <<<< Rippled response has "1" not "1.00"
      }
    },
    destination: {
      address: EURCold,
      amount: {currency: 'EUR'}
    }
  };
  return api.getPaths(pathfind).then(paths => {
    console.log('PATHS: \n', JSON.stringify(paths, null, 2));
  });
}).catch(console.log);

```
@alandotcom
Copy link
Contributor Author

Updated unit test

@clark800
Copy link
Contributor

LGTM

alandotcom added a commit that referenced this pull request Mar 21, 2016
FIX: Filtering source_amount pathfind correctly
@alandotcom alandotcom merged commit 9ffc8a2 into develop Mar 21, 2016
@alandotcom alandotcom deleted the fix/filter-source-amount branch March 21, 2016 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants