New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for node 6 and lodash v4 #800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider folding that last commit into the first.
@@ -1,11 +1,10 @@ | |||
machine: | |||
node: | |||
version: 0.12.0 | |||
version: 6.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these docs which currently say 6.9.0
be updated?
#760
- circle.yml - use node 6 - Fix eslint errors - Update coveralls and add path to babel
- Update ripple-lib-transactionparser
261701a
to
ecd6347
Compare
@wilsonianb Comments addressed - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Rebased and merged with f42dafd |
Also enables ripple-lib to work with node 6
Updating lodash resolves the following error