Remove assert that accesses object post-dtor (RIPD-1704)

XRPLF · Mar 7, 2019 · 1e1e8c2 · 1e1e8c2
1 parent aa49be6
commit 1e1e8c2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/ripple/core/Stoppable.h b/src/ripple/core/Stoppable.h
@@ -327,7 +327,7 @@ class RootStoppable : public Stoppable
 public:
     explicit RootStoppable (std::string name);
 
-    ~RootStoppable ();
+    virtual ~RootStoppable ();
 
     bool isStopping() const;
 

diff --git a/src/ripple/core/impl/Stoppable.cpp b/src/ripple/core/impl/Stoppable.cpp
@@ -42,8 +42,6 @@ Stoppable::Stoppable (std::string name, Stoppable& parent)
 
 Stoppable::~Stoppable ()
 {
-    // Either we must not have started, or Children must be stopped.
-    assert (!m_root.started() || m_childrenStopped);
 }
 
 bool Stoppable::isStopping() const