Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign command only checks build_path parameter's presence, not value (Version: 1.5 beta 5) #3272

Open
carlhua opened this issue Feb 27, 2020 · 1 comment

Comments

@carlhua
Copy link
Contributor

carlhua commented Feb 27, 2020

Issue Description

When processing parameters, the sign command considers "build_path" to be enabled if the parameter is present in the JSON, regardless of what value it has. This is poor API design – because passing "build_path": false basically has the same behavior as "build_path": true.

rippled should actually check the boolean value of the parameter rather than just looking to see whether it's there.

Source:
https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/impl/TransactionSign.cpp#L177-L185

Original reporter @mDuo13 - RIPD-1055

Steps to Reproduce

N/A

Expected Result

N/A

Actual Result

N/A

Environment

N/A

Supporting Files

N/A

@carlhua carlhua assigned ghost Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@mDuo13 @carlhua and others