Move test support sources out of src/ripple (RIPD-1313)
#1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 66.51% (diff: 100%)@@ develop #1916 diff @@
==========================================
Files 692 687 -5
Lines 49482 49314 -168
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 32938 32800 -138
+ Misses 16544 16514 -30
Partials 0 0
|
wilsonianb
approved these changes
Nov 29, 2016
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| #include <ripple/basics/Log.h> | |||
There was a problem hiding this comment.
What do you think about moving PathSet.h to src/test/support/? It looks looks like it is used for app and ledger tests.
|
I wonder why there are 159 fewer Hit lines? |
bachase
added
the
Passed
|
@vinniefalco There were a handful of non-jtx source files (like |
|
Rebased on 0.40.0-rc2 and squashed |
bachase
force-pushed
the
test
branch
2 times, most recently
from
c3c7aa5
to
93cfb2d
Compare
|
Rebased on 0.40.0-rc3 |
|
Rebased on 0.40.0 |
|
Rebased on 0.50.0-b1 |
|
Merged as b6a01ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RIPD-1132, I migrated the unit test sources from
src/rippletosrc/test. These changes move the remaining the unit test support code tosrc/test.src/ripple/jtxandsrc/ripple/maotosrc/testsrc/unitytosrc/test/unitysrc/test, e.g.TestSuite.h,hash_metrics.h,unit_test.h.