Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test support sources out of `src/ripple` (RIPD-1313) #1916

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@bachase
Copy link
Contributor

commented Nov 29, 2016

For RIPD-1132, I migrated the unit test sources from src/ripple to src/test. These changes move the remaining the unit test support code to src/test.

  • Moved src/ripple/jtx and src/ripple/mao to src/test
  • Move src/unity to src/test/unity
  • Move miscellaneous test support files to src/test, e.g. TestSuite.h, hash_metrics.h, unit_test.h.
@codecov-io

This comment has been minimized.

Copy link

commented Nov 29, 2016

Current coverage is 66.51% (diff: 100%)

Merging #1916 into develop will decrease coverage by 0.05%

@@            develop      #1916   diff @@
==========================================
  Files           692        687     -5   
  Lines         49482      49314   -168   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          32938      32800   -138   
+ Misses        16544      16514    -30   
  Partials          0          0          

Powered by Codecov. Last update 8425e45...b6a01ea

@wilsonianb
Copy link

left a comment

👍
According to circleci, there's now 334173 tests total, up from 334110 in 0.40.0-rc1

@@ -22,7 +22,7 @@

#include <ripple/basics/Log.h>

This comment has been minimized.

Copy link
@wilsonianb

wilsonianb Nov 29, 2016

What do you think about moving PathSet.h to src/test/support/? It looks looks like it is used for app and ledger tests.

@vinniefalco

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

I wonder why there are 159 fewer Hit lines?
Anyway 👍

@bachase bachase added the Passed label Dec 7, 2016

@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2016

@vinniefalco There were a handful of non-jtx source files (like src/ripple/basics/TestSuite.h) that were included in the prior coverage measurements because I had only explicitly excluded src/ripple/test in the lcov run. I moved them to src/test/support in this PR, so they are now excluded.

@bachase bachase force-pushed the bachase:test branch from 5e07403 to e550c1b Dec 7, 2016

@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2016

Rebased on 0.40.0-rc2 and squashed

@bachase bachase force-pushed the bachase:test branch 2 times, most recently from c3c7aa5 to 93cfb2d Dec 7, 2016

@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2016

Rebased on 0.40.0-rc3

@bachase bachase force-pushed the bachase:test branch from 93cfb2d to 50cd06d Dec 20, 2016

@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2016

Rebased on 0.40.0

@bachase bachase force-pushed the bachase:test branch from 50cd06d to b6a01ea Dec 28, 2016

@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2016

Rebased on 0.50.0-b1

@bachase bachase merged commit b6a01ea into ripple:develop Jan 3, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8425e45...b6a01ea
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +33.43% compared to 8425e45
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bachase

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2017

Merged as b6a01ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.