Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Fix rpc type-o in two places #2008

Closed
wants to merge 1 commit into from

Conversation

HowardHinnant
Copy link
Contributor

Thanks for spotting this Nik. I searched for more instances of the same bug and found a second example in the same file.

@codecov-io
Copy link

codecov-io commented Feb 9, 2017

Codecov Report

Merging #2008 into develop will decrease coverage by -0.03%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #2008      +/-   ##
===========================================
- Coverage    67.27%   67.25%   -0.03%     
===========================================
  Files          683      683              
  Lines        49231    49231              
===========================================
- Hits         33121    33110      -11     
- Misses       16110    16121      +11
Impacted Files Coverage Δ
src/ripple/rpc/impl/ServerHandlerImp.cpp 76.34% <50%> (ø)
src/ripple/app/misc/impl/LoadFeeTrack.cpp 81.53% <ø> (-4.62%)
src/ripple/beast/core/WaitableEvent.cpp 87.75% <ø> (-4.09%)
src/ripple/server/impl/BaseWSPeer.h 77.5% <ø> (-3.34%)
src/ripple/core/impl/Stoppable.cpp 92.55% <ø> (-3.2%)
src/ripple/app/main/LoadManager.cpp 73.68% <ø> (-1.32%)
src/ripple/basics/impl/make_SSLContext.cpp 53.5% <ø> (+1.27%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209fe8f...fd608c5. Read the comment docs.

Copy link
Contributor

@miguelportilla miguelportilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HowardHinnant
Copy link
Contributor Author

Rebased to 0.60.0-b4

@HowardHinnant HowardHinnant added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Feb 15, 2017
@seelabs
Copy link
Collaborator

seelabs commented Mar 1, 2017

In 0.60.0-b7

@seelabs seelabs closed this Mar 1, 2017
@HowardHinnant HowardHinnant deleted the typeo branch December 6, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants