Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jenkins pipeline for branches #2289

Closed
wants to merge 1 commit into from
Closed

Fix jenkins pipeline for branches #2289

wants to merge 1 commit into from

Conversation

mellery451
Copy link
Contributor

Fixes the jenkins builds on branches - we don't have change related vars in that case. This has been tested in my fork repo.

@ripplelabs-jenkins
Copy link
Collaborator

ripplelabs-jenkins commented Dec 1, 2017

Jenkins Build Summary

Built from this commit

Built at 20171219 - 17:44:28

Test Results

Build Type Result Status
clang.debug.unity 970 cases, 0 failed, t: 383s PASS ✅
coverage 970 cases, 0 failed, t: 607s PASS ✅
clang.debug.nounity 968 cases, 0 failed, t: 292s PASS ✅
gcc.debug.unity 970 cases, 0 failed, t: 422s PASS ✅
gcc.debug.nounity 968 cases, 0 failed, t: 308s PASS ✅
clang.release.unity 969 cases, 0 failed, t: 467s PASS ✅
gcc.release.unity 969 cases, 0 failed, t: 497s PASS ✅

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Dec 7, 2017
@codecov-io
Copy link

Codecov Report

Merging #2289 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2289   +/-   ##
========================================
  Coverage    71.48%   71.48%           
========================================
  Files          697      697           
  Lines        53742    53742           
========================================
  Hits         38417    38417           
  Misses       15325    15325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9e9f4...9f1cff2. Read the comment docs.

@nbougalis nbougalis mentioned this pull request Jan 10, 2018
@seelabs
Copy link
Collaborator

seelabs commented Jan 16, 2018

In 0.90.0-b3

@seelabs seelabs closed this Jan 16, 2018
@mellery451 mellery451 deleted the jenkins-br-fix branch January 16, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants