Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show chapters from comment timestamps #19

Closed
ris58h opened this issue Nov 18, 2022 · 6 comments
Closed

Show chapters from comment timestamps #19

ris58h opened this issue Nov 18, 2022 · 6 comments

Comments

@ris58h
Copy link
Owner

ris58h commented Nov 18, 2022

@Lazyt3ch suggested to show chapters from comment timestamps.
There is a video without chapters but with timestamps in the comments https://www.youtube.com/watch?v=l-joOy1Y2SI .
Seems like we should show chapters from a pinned comment just to be sure.

@Lazyt3ch
Copy link
Contributor

Hi,
I'd like to create a PR related to this issue from a fork of your project.

@ris58h
Copy link
Owner Author

ris58h commented Nov 21, 2022

ok

@ris58h
Copy link
Owner Author

ris58h commented Nov 21, 2022

@Lazyt3ch we need to discuss what comments we consider as chapters comments.

Let's start with your video example https://www.youtube.com/watch?v=l-joOy1Y2SI
The comment that contains chapters:

  • is pinned
  • has more than one timestamp
  • timestamps are in the beginning of the line
  • timestamps are in ascending time order
  • timestamps are less than video duration

Probably we don't need all that requirements to identify chapters comment but it's a good start. What do you think?

@Lazyt3ch
Copy link
Contributor

@Lazyt3ch we need to discuss what comments we consider as chapters comments.

Let's start with your video example https://www.youtube.com/watch?v=l-joOy1Y2SI The comment that contains chapters:

  • is pinned
  • has more than one timestamp
  • timestamps are in the beginning of the line
  • timestamps are in ascending time order
  • timestamps are less than video duration

Probably we don't need all that requirements to identify chapters comment but it's a good start. What do you think?

Actually, all of these suggestions are good. However, chapter comments are a rare thing, so I believe we could just use the top pinned comment if it contains timestamps-like text.

@ris58h ris58h closed this as completed in afaa5cb Nov 21, 2022
@ris58h
Copy link
Owner Author

ris58h commented Nov 22, 2022

@Lazyt3ch version 0.3.0 with your fix is available in Chrome Web Store.

@Lazyt3ch
Copy link
Contributor

@Lazyt3ch version 0.3.0 with your fix is available in Chrome Web Store.

@ris58h Great, thanks for info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants