-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Relay #16
Local Relay #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran things locally and it all makes sense to me. Seems like a good path to get a full local mock of the relay working! Really nice work.
Here are a couple general items I would call out:
- clippy warnings across a few files that might be nice to clear up
- It would be great to get the relay e2e in the github actions CI
- Could we add a new section to the README describing the steps to use the relay that you put in the PR.
- In the README steps you might wanna call out which commands have to be run in new terminals (and how to set the BONSAI_PROVER=... for the relay command
- Could we add logging to the relay when its running in non-query mode? maybe use the tracing_subscriber system at set the log level when its invoked in relay mode. That way a user could see the requests being processed.
Thanks so much for hacking this together!
I noteced that clear build cache (
|
It may happend from reading old GUEST_LIST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that these JSON artifacts are included? It seems like they should not be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the contracts in the relay directory don't get compiled by foundry, but get compiled using ethers-solc
when the solidity_compile
feature flag is passed in, so using this build cache is a shortcut to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure sure, but why does the cache need to be committed to git? By default I would assume it should not be.
I've revised the PR but I've left out the CI and the logging/tracing work for a future PR. |
* Fixed bonsai-sdk / zkvm versions to match api * Updated to newest zkvm in staging
* move functionalities to methods crate lib * copy in relay * trim down relay * switch default cargo run target * rename args * remove todo for chain id label * forge script and refactoring * fixes * fix * lint * tokio subtask for alpha * some clippy lint * readme modifications * remove patch from main workspace * default private key value * clippy, cargo, docs * Fixed bonsai-sdk / zkvm versions to match api (risc0#18) * Fixed bonsai-sdk / zkvm versions to match api * Updated to newest zkvm in staging --------- Co-authored-by: Parker Thompson <parker@risczero.com>
This PR introduces a local simplified Relay in addition to the foundry integration middleware.
Usage